From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [patch] Don't change ctime in truncate is size does not change
Date: Wed, 20 Feb 2008 18:26:15 -0500 [thread overview]
Message-ID: <20080220232615.GA25493@infradead.org> (raw)
In-Reply-To: <20080218233251.GV155407@sgi.com>
> + if (vap->va_size != ip->i_size || mask & XFS_AT_CTIME)
Normal Linux style is to always have braces around the 'foo & bar'
statements to avoid operator precedance problems when re-ordering the
statements. Otherwise this one looks good.
next prev parent reply other threads:[~2008-02-20 23:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 23:32 [patch] Don't change ctime in truncate is size does not change David Chinner
2008-02-18 23:37 ` Mark Goodwin
2008-02-19 1:55 ` David Chinner
2008-02-20 23:26 ` Christoph Hellwig [this message]
2008-02-21 22:50 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080220232615.GA25493@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox