Re: [PATCH] fix mount option pasing to make inode cluster deletion default (again)

["Josef 'Jeff' Sipek" <jeffpc@josefsipek.net>]

On Mon, Feb 18, 2008 at 08:38:28AM -0600, Eric Sandeen wrote:
> Eric Sandeen wrote:
> > mod xfs-linux-melb:xfs-kern:29683a / 
> > git commit 574342f4ad450b33bc85ec53210b8aa8bfff2fcf
> > 
> > broke default options in such a way that empty inode clusters 
> > are no longer deleted by default, because if no options are 
> > given, we "goto done;" without setting the default 
> > XFSMNT_IDELETE flag.
> > 
> > All this logic could probably be rearranged to make things
> > clearer, but for now I think this small patch fixes it:
> > 
> > Set IDELETE a.k.a. "noikeep" by default, but if dmapi is in
> > use, turn it back off (i.e. "ikeep") *unless* noikeep was 
> > specifically requested.
> > 
> > Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> 
> While I like Jeff's patch in the long run... unless you are considering
> submitting it for 2.6.25, might you consider this smaller patch for
> 2.6.25 to fix the inode reclamation problem in the short-term?
 
Yup. Either patch fixes a bug and so it should get sent out rather sooner
than later.

Josef 'Jeff' Sipek.

-- 
Si hoc legere scis nimium eruditionis habes.