public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-dev <xfs-dev@sgi.com>,
	xfs-oss <xfs@oss.sgi.com>
Subject: Re: [patch, debug, 2/2] Use power-of-2 size ktrace buffers
Date: Fri, 22 Feb 2008 19:17:15 -0500	[thread overview]
Message-ID: <20080223001715.GA22614@infradead.org> (raw)
In-Reply-To: <20080222043020.GN155407@sgi.com>

On Fri, Feb 22, 2008 at 03:30:20PM +1100, David Chinner wrote:
> Ok, I'll cook up another patch for that and send it out.

Yeah, making that a separate patch is fine with me.  It's just a logical
next step.

> > a second step ktrace should be replaced with something based on the
> > various trace thingies floating around allowing to read out the trace
> > buffer from userspace instead of having to rely on kdb.
> 
> Yeah, that make sense for tracing from userspace. But most of the
> time I find a need for the tracing is when the machine has crashed
> or assert failed. Hence I don't see that we can really remove the
> kdb side of things. Perhaps two different tracing modules could
> be done.....

It should still be one tracing buffer, with both a userspace space
interface and one from the various kernel debuggers.  Adding the
trace buffers to core dumps in addition would be even better.

      reply	other threads:[~2008-02-23  0:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18 23:01 [patch, debug, 2/2] Use power-of-2 size ktrace buffers David Chinner
2008-02-22  4:08 ` Christoph Hellwig
2008-02-22  4:30   ` David Chinner
2008-02-23  0:17     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080223001715.GA22614@infradead.org \
    --to=hch@infradead.org \
    --cc=dgc@sgi.com \
    --cc=xfs-dev@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox