[PATCH] kill t_sema member of struct xfs_trans

[PATCH] kill t_sema member of struct xfs_trans

[Christoph Hellwig]

It's completely unused so we might aswell kill it.  Note that there is
another t_sema in struct xlog_ticket, which is used and actually an sv_t
despite the name.  That one is left untouched by this patch.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6-xfs/fs/xfs/xfs_trans.h
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/xfs_trans.h	2008-02-05 08:48:40.000000000 +0100
+++ linux-2.6-xfs/fs/xfs/xfs_trans.h	2008-02-05 08:48:45.000000000 +0100
@@ -341,7 +341,6 @@ typedef struct xfs_trans {
 	unsigned int		t_rtx_res;	/* # of rt extents resvd */
 	unsigned int		t_rtx_res_used;	/* # of resvd rt extents used */
 	xfs_log_ticket_t	t_ticket;	/* log mgr ticket */
-	sema_t			t_sema;		/* sema for commit completion */
 	xfs_lsn_t		t_lsn;		/* log seq num of start of
 						 * transaction. */
 	xfs_lsn_t		t_commit_lsn;	/* log seq num of end of

Re: [PATCH] kill t_sema member of struct xfs_trans

[Christoph Hellwig]

On Thu, Feb 07, 2008 at 09:27:24AM +0100, Christoph Hellwig wrote:
> It's completely unused so we might aswell kill it.  Note that there is
> another t_sema in struct xlog_ticket, which is used and actually an sv_t
> despite the name.  That one is left untouched by this patch.

Ping?

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: linux-2.6-xfs/fs/xfs/xfs_trans.h
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/xfs_trans.h	2008-02-05 08:48:40.000000000 +0100
> +++ linux-2.6-xfs/fs/xfs/xfs_trans.h	2008-02-05 08:48:45.000000000 +0100
> @@ -341,7 +341,6 @@ typedef struct xfs_trans {
>  	unsigned int		t_rtx_res;	/* # of rt extents resvd */
>  	unsigned int		t_rtx_res_used;	/* # of resvd rt extents used */
>  	xfs_log_ticket_t	t_ticket;	/* log mgr ticket */
> -	sema_t			t_sema;		/* sema for commit completion */
>  	xfs_lsn_t		t_lsn;		/* log seq num of start of
>  						 * transaction. */
>  	xfs_lsn_t		t_commit_lsn;	/* log seq num of end of
---end quoted text---

Re: [PATCH] kill t_sema member of struct xfs_trans

[Niv Sardi]

* Christoph Hellwig <hch@lst.de> [2008-02-26 18:57:58 +0100]:

> On Thu, Feb 07, 2008 at 09:27:24AM +0100, Christoph Hellwig wrote:
> > It's completely unused so we might aswell kill it.  Note that there is
> > another t_sema in struct xlog_ticket, which is used and actually an sv_t
> > despite the name.  That one is left untouched by this patch.
> 
> Ping?

This seems to be already applied in our dev tree, I'm trying to track down how/when/by-who, appart from that I'm all for pushing it.

Cheers,
-- 
Niv

Re: [PATCH] kill t_sema member of struct xfs_trans

[Timothy Shimmin]

Niv Sardi wrote:
> * Christoph Hellwig <hch@lst.de> [2008-02-26 18:57:58 +0100]:
> 
> Index: linux-2.6-xfs/fs/xfs/xfs_trans.h
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/xfs_trans.h	2008-02-05 08:48:40.000000000 +0100
> +++ linux-2.6-xfs/fs/xfs/xfs_trans.h	2008-02-05 08:48:45.000000000 +0100
> @@ -341,7 +341,6 @@ typedef struct xfs_trans {
>  	unsigned int		t_rtx_res;	/* # of rt extents resvd */
>  	unsigned int		t_rtx_res_used;	/* # of resvd rt extents used */
>  	xfs_log_ticket_t	t_ticket;	/* log mgr ticket */
> -	sema_t			t_sema;		/* sema for commit completion */
>  	xfs_lsn_t		t_lsn;		/* log seq num of start of
>  						 * transaction. */
>  	xfs_lsn_t		t_commit_lsn;	/* log seq num of end of

>> On Thu, Feb 07, 2008 at 09:27:24AM +0100, Christoph Hellwig wrote:
>>> It's completely unused so we might aswell kill it.  Note that there is
>>> another t_sema in struct xlog_ticket, which is used and actually an sv_t
>>> despite the name.  That one is left untouched by this patch.
>> Ping?
> 
> This seems to be already applied in our dev tree, I'm trying to track down how/when/by-who, appart from that I'm all for pushing it.
> 
> Cheers,

Niv, it still seems to be in our dev tree for me:

 > p_cat -farm xfs_trans.h | grep -C 3 t_sema
doucette  |1.22 |                            |	unsigned int		t_rtx_res;	/* # of rt extents resvd */
cattelan  |1.118|2.4.x-xfs:slinx:144573a     |	unsigned int		t_rtx_res_used;	/* # of resvd rt extents used */
ajs       |1.13 |                            |	xfs_log_ticket_t	t_ticket;	/* log mgr ticket */
ajs       |1.11 |                            |	sema_t			t_sema;		/* sema for commit completion */
lord      |1.114|2.4.x-xfs:slinx:129778a     |	xfs_lsn_t		t_lsn;		/* log seq num of start of
lord      |1.114|2.4.x-xfs:slinx:129778a     |						 * transaction. */
cattelan  |1.118|2.4.x-xfs:slinx:144573a     |	xfs_lsn_t		t_commit_lsn;	/* log seq num of end of

--Tim

Re: [PATCH] kill t_sema member of struct xfs_trans

[Eric Sandeen]

Timothy Shimmin wrote:

> Niv, it still seems to be in our dev tree for me:

And if it were checked in, where's the TAKE message?  :)

-Eric