public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH, mainline-only] remove dmapi cruft in xfs_file.c
Date: Fri, 29 Feb 2008 00:30:48 +0100	[thread overview]
Message-ID: <20080228233047.GA29818@lst.de> (raw)
In-Reply-To: <47C73849.3090406@sandeen.net>

On Thu, Feb 28, 2008 at 04:40:09PM -0600, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > The dmapi cruft in xfs_file.c is totally out of date in mainline vs
> > CVS, and at this point just removing this code which can't be used on
> > mainline at all seems to be the best option to keep it maintainable.
> 
> When doing this should probably whack the:
> 
> #ifdef HAVE_FOP_OPEN_EXEC
>         .open_exec      = xfs_file_open_exec,
> #endif
> 
> from xfs_file_operations, too?

Yes,  but no urgeny for now as we've missed the .25 window anyway.

      reply	other threads:[~2008-02-28 23:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08  4:44 [PATCH, mainline-only] remove dmapi cruft in xfs_file.c Christoph Hellwig
2008-02-20  3:59 ` Niv Sardi
2008-02-22  3:26 ` Niv Sardi
2008-02-28 22:40 ` Eric Sandeen
2008-02-28 23:30   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080228233047.GA29818@lst.de \
    --to=hch@lst.de \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox