public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: donaldd@sgi.com
To: sgi.bugs.xfs@engr.sgi.com, xfs@oss.sgi.com
Subject: TAKE 976035 - Remove superflous xfs_readsb call in xfs_mountfs.
Date: Mon,  3 Mar 2008 11:42:01 +1100 (EST)	[thread overview]
Message-ID: <20080303004201.C3753323900C@linuxbuild.melbourne.sgi.com> (raw)

Remove superflous xfs_readsb call in xfs_mountfs.

When xfs_mountfs is called by xfs_mount xfs_readsb was called 35 lines
above unconditionally, so there is no need to try to read the superblock
if it's not present.  If any other port doesn't have the superblock
read at this point it should just call it directly from it's xfs_mount
equivalent.


Signed-off-by: Christoph Hellwig <hch@lst.de>


Date:  Mon Mar  3 11:41:13 AEDT 2008
Workarea:  linuxbuild.melbourne.sgi.com:/home/donaldd/isms/2.6.x-xfs
Inspected by:  donaldd

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:30603a
fs/xfs/xfs_mount.c - 1.420 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_mount.c.diff?r1=text&tr1=1.420&r2=text&tr2=1.419&f=h
	- Remove superflous xfs_readsb call in xfs_mountfs.

                 reply	other threads:[~2008-03-03  0:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080303004201.C3753323900C@linuxbuild.melbourne.sgi.com \
    --to=donaldd@sgi.com \
    --cc=sgi.bugs.xfs@engr.sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox