From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounce@oss.sgi.com>
Received: with ECARTIS (v1.0.0; list xfs); Sun, 02 Mar 2008 20:04:45 -0800 (PST)
Received: from cuda.sgi.com (cuda2.sgi.com [192.48.168.29])
	by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m2344ZAC001986
	for <xfs@oss.sgi.com>; Sun, 2 Mar 2008 20:04:38 -0800
Date: Sun, 2 Mar 2008 23:04:58 -0500
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [patch] fix inode leak in xfs_iget_core()
Message-ID: <20080303040458.GA3177@infradead.org>
References: <20080223061924.GI155259@sgi.com> <20080223092255.GA21453@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080223092255.GA21453@infradead.org>
Sender: xfs-bounce@oss.sgi.com
Errors-to: xfs-bounce@oss.sgi.com
List-Id: xfs
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>

On Sat, Feb 23, 2008 at 04:22:55AM -0500, Christoph Hellwig wrote:
> On Sat, Feb 23, 2008 at 05:19:24PM +1100, David Chinner wrote:
> > If the radix_tree_preload() fails, we need to destroy the
> > inode we just read in before trying again. This could leak
> > xfs_vnode structures when there is memory pressure. Noticed
> > by Christoph Hellwig.
> 
> What we're leaking would be the xfs_inode.  But this is exactly
> the patch I had so OK from me :)

Now that you're hopefully safe home can you commit it and push it
for .25?