public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fix xfsqa 049 when using whole scratch device
@ 2008-03-20  2:33 Eric Sandeen
  2008-03-20  7:35 ` Christoph Hellwig
  2008-03-20 20:37 ` Josef 'Jeff' Sipek
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2008-03-20  2:33 UTC (permalink / raw)
  To: xfs-oss

if SCRATCH_DEV happens to be a whole device, mke2fs will wait
for confirmation.

(mke2fs -F would work, too...)

-Eric

Index: xfs-cmds/xfstests/049
===================================================================
--- xfs-cmds.orig/xfstests/049
+++ xfs-cmds/xfstests/049
@@ -60,7 +60,7 @@ echo "--- mounts" >> $seq.full
 mount >> $seq.full
 
 _log "Create ext2 fs on scratch"
-mkfs -t ext2 $SCRATCH_DEV >> $seq.full 2>&1 \
+echo y | mkfs -t ext2 $SCRATCH_DEV >> $seq.full 2>&1 \
     || _fail "!!! failed to mkfs ext2"
 
 _log "Mount ext2 fs on scratch"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fix xfsqa 049 when using whole scratch device
  2008-03-20  2:33 [PATCH] fix xfsqa 049 when using whole scratch device Eric Sandeen
@ 2008-03-20  7:35 ` Christoph Hellwig
  2008-03-20 20:37 ` Josef 'Jeff' Sipek
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2008-03-20  7:35 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: xfs-oss

On Wed, Mar 19, 2008 at 09:33:20PM -0500, Eric Sandeen wrote:
> if SCRATCH_DEV happens to be a whole device, mke2fs will wait
> for confirmation.
> 
> (mke2fs -F would work, too...)

Looks good.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fix xfsqa 049 when using whole scratch device
  2008-03-20  2:33 [PATCH] fix xfsqa 049 when using whole scratch device Eric Sandeen
  2008-03-20  7:35 ` Christoph Hellwig
@ 2008-03-20 20:37 ` Josef 'Jeff' Sipek
  1 sibling, 0 replies; 3+ messages in thread
From: Josef 'Jeff' Sipek @ 2008-03-20 20:37 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: xfs-oss

On Wed, Mar 19, 2008 at 09:33:20PM -0500, Eric Sandeen wrote:
> if SCRATCH_DEV happens to be a whole device, mke2fs will wait
> for confirmation.
> 
> (mke2fs -F would work, too...)

Tested; does NOT cause a regression.

Josef 'Jeff' Sipek.

-- 
Failure is not an option,
It comes bundled with your Microsoft product.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-03-20 20:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-20  2:33 [PATCH] fix xfsqa 049 when using whole scratch device Eric Sandeen
2008-03-20  7:35 ` Christoph Hellwig
2008-03-20 20:37 ` Josef 'Jeff' Sipek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox