From: "Josef 'Jeff' Sipek" <jeffpc@josefsipek.net>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] cleanup root inode handling in xfs_fs_fill_super
Date: Fri, 21 Mar 2008 14:06:43 -0400 [thread overview]
Message-ID: <20080321180643.GC5433@josefsipek.net> (raw)
In-Reply-To: <20080319204724.GA24271@lst.de>
On Wed, Mar 19, 2008 at 09:47:24PM +0100, Christoph Hellwig wrote:
> - rename rootvp to root for clarify
> - remove useless vn_to_inode call
> - check is_bad_inode before calling d_alloc_root
> - use iput instead of VN_RELE in the error case
Looks good.
Josef 'Jeff' Sipek.
--
FORTUNE PROVIDES QUESTIONS FOR THE GREAT ANSWERS: #19
A: To be or not to be.
Q: What is the square root of 4b^2?
prev parent reply other threads:[~2008-03-21 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 20:47 [PATCH] cleanup root inode handling in xfs_fs_fill_super Christoph Hellwig
2008-03-21 18:06 ` Josef 'Jeff' Sipek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080321180643.GC5433@josefsipek.net \
--to=jeffpc@josefsipek.net \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox