Re: [patch] detect and correct bad features2 superblock field

["Josef 'Jeff' Sipek" <jeffpc@josefsipek.net>]

On Sat, Mar 29, 2008 at 11:53:40PM -0500, Eric Sandeen wrote:
> Josef 'Jeff' Sipek wrote:
> > On Sat, Mar 29, 2008 at 08:30:00PM -0500, Eric Sandeen wrote:
> 
> >> Hm, the other problem here may be that if we zero bad_features2, then
> >> any older kernel will mount up as attr2... and run into the corruption
> >> problem I found on F8...
> >>
> >> Should we make features2 and bad_features2 match rather than zeroing
> >> bad_features2?
> > 
> > I thought that was discussed here (or was it on IRC?), and the conclusion
> > was the best way is to always have features2 == bad_features2.  It is the
> > safest way to handle things - the filesystem is guaranteed to work
> > everywhere properly (old & new kernels).  Both the userspace (xfs_repair)
> > and kernel have to of course do the same thing (or bad_features2 with
> > features2, and save the result in both locations).
> > 
> > At least that's what I seem to remember.
> > 
> > Josef 'Jeff' Sipek.
> > 
> 
> It might have been, but it's not what was checked in... *shrug*
> 
> http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_mount.c#rev1.419

I remember the discussion taking place _after_ that commit..so it must have
been userspace-related.

Josef 'Jeff' Sipek.

-- 
I'm somewhere between geek and normal.
		- Linus Torvalds