From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [Patch] Remove xlog_ticket allocator
Date: Mon, 7 Apr 2008 08:46:13 -0400 [thread overview]
Message-ID: <20080407124613.GA27350@infradead.org> (raw)
In-Reply-To: <20080401231439.GU103491721@sgi.com>
On Wed, Apr 02, 2008 at 09:14:39AM +1000, David Chinner wrote:
> ===================================================================
> --- 2.6.x-xfs-new.orig/fs/xfs/xfs_vfsops.c 2008-03-13 13:58:08.866070224 +1100
> +++ 2.6.x-xfs-new/fs/xfs/xfs_vfsops.c 2008-03-13 13:59:59.208010688 +1100
> @@ -68,15 +68,17 @@ xfs_init(void)
> /*
> * Initialize all of the zone allocators we use.
> */
> + xfs_log_ticket_zone = kmem_zone_init(sizeof(xlog_ticket_t),
> + "xfs_log_ticket");
> xfs_bmap_free_item_zone = kmem_zone_init(sizeof(xfs_bmap_free_item_t),
> - "xfs_bmap_free_item");
> + "xfs_bmap_free_item");
> xfs_btree_cur_zone = kmem_zone_init(sizeof(xfs_btree_cur_t),
> - "xfs_btree_cur");
> - xfs_trans_zone = kmem_zone_init(sizeof(xfs_trans_t), "xfs_trans");
> - xfs_da_state_zone =
> - kmem_zone_init(sizeof(xfs_da_state_t), "xfs_da_state");
> + "xfs_btree_cur");
> + xfs_da_state_zone = kmem_zone_init(sizeof(xfs_da_state_t),
> + "xfs_da_state");
> xfs_dabuf_zone = kmem_zone_init(sizeof(xfs_dabuf_t), "xfs_dabuf");
> xfs_ifork_zone = kmem_zone_init(sizeof(xfs_ifork_t), "xfs_ifork");
> + xfs_trans_zone = kmem_zone_init(sizeof(xfs_trans_t), "xfs_trans");
kmem_zone_init can fail so both for the new and old calls we need
some error handling here. Could probably be a separate patch.
Otherwise this looks fine.
prev parent reply other threads:[~2008-04-07 12:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-01 23:14 [Patch] Remove xlog_ticket allocator David Chinner
2008-04-02 6:22 ` Lachlan McIlroy
2008-04-07 12:46 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080407124613.GA27350@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox