public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [patch] xfsqa - 008 is unreliable on 64k page size
@ 2008-04-08  1:38 David Chinner
  2008-04-10  4:42 ` David Chinner
  2008-04-28  5:55 ` Christoph Hellwig
  0 siblings, 2 replies; 4+ messages in thread
From: David Chinner @ 2008-04-08  1:38 UTC (permalink / raw)
  To: xfs-dev; +Cc: xfs-oss

Test 008 is unreliable on 64k page size. The I/O size is large
enough that the probability of extent merging results in intermittent
failures due to fewer extents that the +/- 10% tolerance allows.

Fix by making the files larger.

Signed-off-by: Dave Chinner <dgc@sgi.com>
---
 xfstests/008     |   10 +++++-----
 xfstests/008.out |   10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

Index: xfs-cmds/xfstests/008
===================================================================
--- xfs-cmds.orig/xfstests/008	2006-11-14 19:57:39.000000000 +1100
+++ xfs-cmds/xfstests/008	2008-04-08 10:18:10.641024202 +1000
@@ -79,13 +79,13 @@ _setup_testdir
 
 rm -f $here/$seq.out.full
 
-_do_test 1 50 "-l 5000000 -c 50 -b $pgsize"
-_do_test 2 100 "-l 10000000 -c 100 -b $pgsize"
-_do_test 3 100 "-l 10000000 -c 100 -b 512"   # test partial pages
+_do_test 1 50 "-l 50000000 -c 50 -b $pgsize"
+_do_test 2 100 "-l 100000000 -c 100 -b $pgsize"
+_do_test 3 100 "-l 100000000 -c 100 -b 512"   # test partial pages
 
 # rinse, lather, repeat for direct IO
-_do_test 4 50 "-d -l 5000000 -c 50 -b $pgsize"
-_do_test 5 100 "-d -l 10000000 -c 100 -b $pgsize"
+_do_test 4 50 "-d -l 50000000 -c 50 -b $pgsize"
+_do_test 5 100 "-d -l 100000000 -c 100 -b $pgsize"
 # note: direct IO requires page aligned IO
 
 # todo: realtime.
Index: xfs-cmds/xfstests/008.out
===================================================================
--- xfs-cmds.orig/xfstests/008.out	2006-11-14 19:57:39.000000000 +1100
+++ xfs-cmds/xfstests/008.out	2008-04-08 11:25:52.584176769 +1000
@@ -1,21 +1,21 @@
 QA output created by 008
 
-randholes.1 : -l 5000000 -c 50 -b PGSIZE
+randholes.1 : -l 50000000 -c 50 -b PGSIZE
 ------------------------------------------
 holes is in range
 
-randholes.2 : -l 10000000 -c 100 -b PGSIZE
+randholes.2 : -l 100000000 -c 100 -b PGSIZE
 ------------------------------------------
 holes is in range
 
-randholes.3 : -l 10000000 -c 100 -b 512
+randholes.3 : -l 100000000 -c 100 -b 512
 ------------------------------------------
 holes is in range
 
-randholes.4 : -d -l 5000000 -c 50 -b PGSIZE
+randholes.4 : -d -l 50000000 -c 50 -b PGSIZE
 ------------------------------------------
 holes is in range
 
-randholes.5 : -d -l 10000000 -c 100 -b PGSIZE
+randholes.5 : -d -l 100000000 -c 100 -b PGSIZE
 ------------------------------------------
 holes is in range

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] xfsqa - 008 is unreliable on 64k page size
  2008-04-08  1:38 [patch] xfsqa - 008 is unreliable on 64k page size David Chinner
@ 2008-04-10  4:42 ` David Chinner
  2008-04-28  4:00   ` David Chinner
  2008-04-28  5:55 ` Christoph Hellwig
  1 sibling, 1 reply; 4+ messages in thread
From: David Chinner @ 2008-04-10  4:42 UTC (permalink / raw)
  To: David Chinner; +Cc: xfs-dev, xfs-oss

Ping?

On Tue, Apr 08, 2008 at 11:38:33AM +1000, David Chinner wrote:
> Test 008 is unreliable on 64k page size. The I/O size is large
> enough that the probability of extent merging results in intermittent
> failures due to fewer extents that the +/- 10% tolerance allows.
> 
> Fix by making the files larger.
> 
> Signed-off-by: Dave Chinner <dgc@sgi.com>
> ---
>  xfstests/008     |   10 +++++-----
>  xfstests/008.out |   10 +++++-----
>  2 files changed, 10 insertions(+), 10 deletions(-)
> 
> Index: xfs-cmds/xfstests/008
> ===================================================================
> --- xfs-cmds.orig/xfstests/008	2006-11-14 19:57:39.000000000 +1100
> +++ xfs-cmds/xfstests/008	2008-04-08 10:18:10.641024202 +1000
> @@ -79,13 +79,13 @@ _setup_testdir
>  
>  rm -f $here/$seq.out.full
>  
> -_do_test 1 50 "-l 5000000 -c 50 -b $pgsize"
> -_do_test 2 100 "-l 10000000 -c 100 -b $pgsize"
> -_do_test 3 100 "-l 10000000 -c 100 -b 512"   # test partial pages
> +_do_test 1 50 "-l 50000000 -c 50 -b $pgsize"
> +_do_test 2 100 "-l 100000000 -c 100 -b $pgsize"
> +_do_test 3 100 "-l 100000000 -c 100 -b 512"   # test partial pages
>  
>  # rinse, lather, repeat for direct IO
> -_do_test 4 50 "-d -l 5000000 -c 50 -b $pgsize"
> -_do_test 5 100 "-d -l 10000000 -c 100 -b $pgsize"
> +_do_test 4 50 "-d -l 50000000 -c 50 -b $pgsize"
> +_do_test 5 100 "-d -l 100000000 -c 100 -b $pgsize"
>  # note: direct IO requires page aligned IO
>  
>  # todo: realtime.
> Index: xfs-cmds/xfstests/008.out
> ===================================================================
> --- xfs-cmds.orig/xfstests/008.out	2006-11-14 19:57:39.000000000 +1100
> +++ xfs-cmds/xfstests/008.out	2008-04-08 11:25:52.584176769 +1000
> @@ -1,21 +1,21 @@
>  QA output created by 008
>  
> -randholes.1 : -l 5000000 -c 50 -b PGSIZE
> +randholes.1 : -l 50000000 -c 50 -b PGSIZE
>  ------------------------------------------
>  holes is in range
>  
> -randholes.2 : -l 10000000 -c 100 -b PGSIZE
> +randholes.2 : -l 100000000 -c 100 -b PGSIZE
>  ------------------------------------------
>  holes is in range
>  
> -randholes.3 : -l 10000000 -c 100 -b 512
> +randholes.3 : -l 100000000 -c 100 -b 512
>  ------------------------------------------
>  holes is in range
>  
> -randholes.4 : -d -l 5000000 -c 50 -b PGSIZE
> +randholes.4 : -d -l 50000000 -c 50 -b PGSIZE
>  ------------------------------------------
>  holes is in range
>  
> -randholes.5 : -d -l 10000000 -c 100 -b PGSIZE
> +randholes.5 : -d -l 100000000 -c 100 -b PGSIZE
>  ------------------------------------------
>  holes is in range

-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] xfsqa - 008 is unreliable on 64k page size
  2008-04-10  4:42 ` David Chinner
@ 2008-04-28  4:00   ` David Chinner
  0 siblings, 0 replies; 4+ messages in thread
From: David Chinner @ 2008-04-28  4:00 UTC (permalink / raw)
  To: David Chinner; +Cc: xfs-dev, xfs-oss

ping again?

On Thu, Apr 10, 2008 at 02:42:59PM +1000, David Chinner wrote:
> Ping?
> 
> On Tue, Apr 08, 2008 at 11:38:33AM +1000, David Chinner wrote:
> > Test 008 is unreliable on 64k page size. The I/O size is large
> > enough that the probability of extent merging results in intermittent
> > failures due to fewer extents that the +/- 10% tolerance allows.
> > 
> > Fix by making the files larger.
> > 
> > Signed-off-by: Dave Chinner <dgc@sgi.com>
> > ---
> >  xfstests/008     |   10 +++++-----
> >  xfstests/008.out |   10 +++++-----
> >  2 files changed, 10 insertions(+), 10 deletions(-)
> > 
> > Index: xfs-cmds/xfstests/008
> > ===================================================================
> > --- xfs-cmds.orig/xfstests/008	2006-11-14 19:57:39.000000000 +1100
> > +++ xfs-cmds/xfstests/008	2008-04-08 10:18:10.641024202 +1000
> > @@ -79,13 +79,13 @@ _setup_testdir
> >  
> >  rm -f $here/$seq.out.full
> >  
> > -_do_test 1 50 "-l 5000000 -c 50 -b $pgsize"
> > -_do_test 2 100 "-l 10000000 -c 100 -b $pgsize"
> > -_do_test 3 100 "-l 10000000 -c 100 -b 512"   # test partial pages
> > +_do_test 1 50 "-l 50000000 -c 50 -b $pgsize"
> > +_do_test 2 100 "-l 100000000 -c 100 -b $pgsize"
> > +_do_test 3 100 "-l 100000000 -c 100 -b 512"   # test partial pages
> >  
> >  # rinse, lather, repeat for direct IO
> > -_do_test 4 50 "-d -l 5000000 -c 50 -b $pgsize"
> > -_do_test 5 100 "-d -l 10000000 -c 100 -b $pgsize"
> > +_do_test 4 50 "-d -l 50000000 -c 50 -b $pgsize"
> > +_do_test 5 100 "-d -l 100000000 -c 100 -b $pgsize"
> >  # note: direct IO requires page aligned IO
> >  
> >  # todo: realtime.
> > Index: xfs-cmds/xfstests/008.out
> > ===================================================================
> > --- xfs-cmds.orig/xfstests/008.out	2006-11-14 19:57:39.000000000 +1100
> > +++ xfs-cmds/xfstests/008.out	2008-04-08 11:25:52.584176769 +1000
> > @@ -1,21 +1,21 @@
> >  QA output created by 008
> >  
> > -randholes.1 : -l 5000000 -c 50 -b PGSIZE
> > +randholes.1 : -l 50000000 -c 50 -b PGSIZE
> >  ------------------------------------------
> >  holes is in range
> >  
> > -randholes.2 : -l 10000000 -c 100 -b PGSIZE
> > +randholes.2 : -l 100000000 -c 100 -b PGSIZE
> >  ------------------------------------------
> >  holes is in range
> >  
> > -randholes.3 : -l 10000000 -c 100 -b 512
> > +randholes.3 : -l 100000000 -c 100 -b 512
> >  ------------------------------------------
> >  holes is in range
> >  
> > -randholes.4 : -d -l 5000000 -c 50 -b PGSIZE
> > +randholes.4 : -d -l 50000000 -c 50 -b PGSIZE
> >  ------------------------------------------
> >  holes is in range
> >  
> > -randholes.5 : -d -l 10000000 -c 100 -b PGSIZE
> > +randholes.5 : -d -l 100000000 -c 100 -b PGSIZE
> >  ------------------------------------------
> >  holes is in range
> 
> -- 
> Dave Chinner
> Principal Engineer
> SGI Australian Software Group

-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] xfsqa - 008 is unreliable on 64k page size
  2008-04-08  1:38 [patch] xfsqa - 008 is unreliable on 64k page size David Chinner
  2008-04-10  4:42 ` David Chinner
@ 2008-04-28  5:55 ` Christoph Hellwig
  1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2008-04-28  5:55 UTC (permalink / raw)
  To: David Chinner; +Cc: xfs-dev, xfs-oss

On Tue, Apr 08, 2008 at 11:38:33AM +1000, David Chinner wrote:
> Test 008 is unreliable on 64k page size. The I/O size is large
> enough that the probability of extent merging results in intermittent
> failures due to fewer extents that the +/- 10% tolerance allows.

Looks good.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-04-28  5:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-08  1:38 [patch] xfsqa - 008 is unreliable on 64k page size David Chinner
2008-04-10  4:42 ` David Chinner
2008-04-28  4:00   ` David Chinner
2008-04-28  5:55 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox