public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Chinner <dgc@sgi.com>
To: xfs-dev <xfs-dev@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: [patch] xfsqa 185 - remove uninitialised variables in golden output.
Date: Tue, 8 Apr 2008 11:40:23 +1000	[thread overview]
Message-ID: <20080408014023.GO108924158@sgi.com> (raw)

Kill the output of uninitialised values when punching a hole.
This prevents the test from passing on just about everything.

Signed-off-by: Dave Chinner <dgc@sgi.com>
---
 xfstests/185.out                                        |    5 -----
 xfstests/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c |    2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)

Index: xfs-cmds/xfstests/185.out
===================================================================
--- xfs-cmds.orig/xfstests/185.out	2008-03-13 17:49:31.000000000 +1100
+++ xfs-cmds/xfstests/185.out	2008-04-08 11:31:30.520670188 +1000
@@ -12,7 +12,6 @@ roffp is 0, rlenp is 16384
 Method:	dmapi_punch
 Running DMAPI punch hole on /mnt/scratch/dmapi/holly_file with settings:
   offset = '0', length = '16384', sid = '0'
-roffp is 4200149, rlenp is 47820330485640
 =======================================================
 =======================================================
 Testing with length = 1k, offset = 0
@@ -27,7 +26,6 @@ roffp is 0, rlenp is 1024
 Method:	dmapi_punch
 Running DMAPI punch hole on /mnt/scratch/dmapi/holly_file with settings:
   offset = '0', length = '1024', sid = '0'
-roffp is 4200149, rlenp is 47194545715080
 =======================================================
 =======================================================
 Testing with length = 1k, offset = 4k
@@ -42,7 +40,6 @@ roffp is 4096, rlenp is 1024
 Method:	dmapi_punch
 Running DMAPI punch hole on /mnt/scratch/dmapi/holly_file with settings:
   offset = '4096', length = '1024', sid = '0'
-roffp is 4200149, rlenp is 47256598480776
 =======================================================
 =======================================================
 Testing with length = 4k, offset = 1k
@@ -57,7 +54,6 @@ roffp is 1024, rlenp is 4096
 Method:	dmapi_punch
 Running DMAPI punch hole on /mnt/scratch/dmapi/holly_file with settings:
   offset = '1024', length = '4096', sid = '0'
-roffp is 4200149, rlenp is 47292581427080
 =======================================================
 =======================================================
 Testing with length = 1024k, offset = 512k
@@ -72,5 +68,4 @@ roffp is 524288, rlenp is 1048576
 Method:	dmapi_punch
 Running DMAPI punch hole on /mnt/scratch/dmapi/holly_file with settings:
   offset = '524288', length = '1048576', sid = '0'
-roffp is 4200149, rlenp is 47016592795528
 =======================================================
Index: xfs-cmds/xfstests/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c
===================================================================
--- xfs-cmds.orig/xfstests/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c	2008-03-13 17:49:31.000000000 +1100
+++ xfs-cmds/xfstests/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c	2008-04-08 11:30:32.032200700 +1000
@@ -176,6 +176,7 @@ main(
 				strerror(errno));
 			exit(1);
 		}
+		fprintf(stdout, "roffp is %lld, rlenp is %lld\n", roffp, rlenp);
 		break;
 	case METHOD_DMAPI_PUNCH:
 		if (dm_punch_hole(sid, hanp, hlen, DM_NO_TOKEN, offset, length)) {
@@ -185,7 +186,6 @@ main(
 		}
 		break;			
 	}
-	fprintf(stdout, "roffp is %lld, rlenp is %lld\n", roffp, rlenp);
 	dm_handle_free(hanp, hlen);
 	
 	return 0;

             reply	other threads:[~2008-04-08  1:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-08  1:40 David Chinner [this message]
2008-04-08  4:43 ` [patch] xfsqa 185 - remove uninitialised variables in golden output Niv Sardi
2008-04-08  4:47   ` David Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080408014023.GO108924158@sgi.com \
    --to=dgc@sgi.com \
    --cc=xfs-dev@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox