[patch] xfsqa 185 - remove uninitialised variables in golden output.

[patch] xfsqa 185 - remove uninitialised variables in golden output.

[David Chinner]

Kill the output of uninitialised values when punching a hole.
This prevents the test from passing on just about everything.

Signed-off-by: Dave Chinner <dgc@sgi.com>
---
 xfstests/185.out                                        |    5 -----
 xfstests/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c |    2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)

Index: xfs-cmds/xfstests/185.out
===================================================================
--- xfs-cmds.orig/xfstests/185.out	2008-03-13 17:49:31.000000000 +1100
+++ xfs-cmds/xfstests/185.out	2008-04-08 11:31:30.520670188 +1000
@@ -12,7 +12,6 @@ roffp is 0, rlenp is 16384
 Method:	dmapi_punch
 Running DMAPI punch hole on /mnt/scratch/dmapi/holly_file with settings:
   offset = '0', length = '16384', sid = '0'
-roffp is 4200149, rlenp is 47820330485640
 =======================================================
 =======================================================
 Testing with length = 1k, offset = 0
@@ -27,7 +26,6 @@ roffp is 0, rlenp is 1024
 Method:	dmapi_punch
 Running DMAPI punch hole on /mnt/scratch/dmapi/holly_file with settings:
   offset = '0', length = '1024', sid = '0'
-roffp is 4200149, rlenp is 47194545715080
 =======================================================
 =======================================================
 Testing with length = 1k, offset = 4k
@@ -42,7 +40,6 @@ roffp is 4096, rlenp is 1024
 Method:	dmapi_punch
 Running DMAPI punch hole on /mnt/scratch/dmapi/holly_file with settings:
   offset = '4096', length = '1024', sid = '0'
-roffp is 4200149, rlenp is 47256598480776
 =======================================================
 =======================================================
 Testing with length = 4k, offset = 1k
@@ -57,7 +54,6 @@ roffp is 1024, rlenp is 4096
 Method:	dmapi_punch
 Running DMAPI punch hole on /mnt/scratch/dmapi/holly_file with settings:
   offset = '1024', length = '4096', sid = '0'
-roffp is 4200149, rlenp is 47292581427080
 =======================================================
 =======================================================
 Testing with length = 1024k, offset = 512k
@@ -72,5 +68,4 @@ roffp is 524288, rlenp is 1048576
 Method:	dmapi_punch
 Running DMAPI punch hole on /mnt/scratch/dmapi/holly_file with settings:
   offset = '524288', length = '1048576', sid = '0'
-roffp is 4200149, rlenp is 47016592795528
 =======================================================
Index: xfs-cmds/xfstests/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c
===================================================================
--- xfs-cmds.orig/xfstests/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c	2008-03-13 17:49:31.000000000 +1100
+++ xfs-cmds/xfstests/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c	2008-04-08 11:30:32.032200700 +1000
@@ -176,6 +176,7 @@ main(
 				strerror(errno));
 			exit(1);
 		}
+		fprintf(stdout, "roffp is %lld, rlenp is %lld\n", roffp, rlenp);
 		break;
 	case METHOD_DMAPI_PUNCH:
 		if (dm_punch_hole(sid, hanp, hlen, DM_NO_TOKEN, offset, length)) {
@@ -185,7 +186,6 @@ main(
 		}
 		break;			
 	}
-	fprintf(stdout, "roffp is %lld, rlenp is %lld\n", roffp, rlenp);
 	dm_handle_free(hanp, hlen);
 	
 	return 0;

Re: [patch] xfsqa 185 - remove uninitialised variables in golden output.

[Niv Sardi]

David Chinner <dgc@sgi.com> writes:

> Kill the output of uninitialised values when punching a hole.
> This prevents the test from passing on just about everything.
>
> Signed-off-by: Dave Chinner <dgc@sgi.com>

Thanks dave, I've been meaning to do that for a long time, we might want
to kill the sid output too when it's not specified on command line (can
that change ? I've always seen it as 0).

Cheers,
-- 
Niv Sardi

Re: [patch] xfsqa 185 - remove uninitialised variables in golden output.

[David Chinner]

On Tue, Apr 08, 2008 at 02:43:15PM +1000, Niv Sardi wrote:
> David Chinner <dgc@sgi.com> writes:
> 
> > Kill the output of uninitialised values when punching a hole.
> > This prevents the test from passing on just about everything.
> >
> > Signed-off-by: Dave Chinner <dgc@sgi.com>
> 
> Thanks dave, I've been meaning to do that for a long time, we might want
> to kill the sid output too when it's not specified on command line (can
> that change ? I've always seen it as 0).

no idea. You can remove it as a separate patch if it is a problem. I'm
going to check this one in now ;)

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group