From: Christoph Hellwig <hch@infradead.org>
To: Barry Naujok <bnaujok@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>, xfs-dev <xfs-dev@sgi.com>
Subject: Re: [REVIEW #2] cleanup - remove bhv_vname_t
Date: Tue, 8 Apr 2008 06:48:51 -0400 [thread overview]
Message-ID: <20080408104851.GA25647@infradead.org> (raw)
In-Reply-To: <20080408085153.GA19699@infradead.org>
On Tue, Apr 08, 2008 at 04:51:53AM -0400, Christoph Hellwig wrote:
> > +static inline int
> > +xfs_dir_check_canenter(uint resblks, struct xfs_trans *tp,
> > + struct xfs_inode *dp, struct xfs_name *name)
> > +{
> > + if (resblks)
> > + return 0;
> > + return xfs_dir_canenter(tp, dp, name);;
> > +}
>
> Probably makes sense to have this out of line.
Actuallt this is the only caller of xfs_dir_canenter with your patch so
you should merge the resblks check into xfs_dir_canenter. Please also
add a comment on why we do the check. Also resblks is normally the
last argument to functions, we should follow that convention here.
next prev parent reply other threads:[~2008-04-08 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 7:38 [REVIEW #2] cleanup - remove bhv_vname_t Barry Naujok
2008-04-08 8:51 ` Christoph Hellwig
2008-04-08 10:48 ` Christoph Hellwig [this message]
2008-04-09 4:01 ` Barry Naujok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080408104851.GA25647@infradead.org \
--to=hch@infradead.org \
--cc=bnaujok@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox