From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [patch] ensure inodes are joined in xfs_itruncate_finish
Date: Thu, 10 Apr 2008 02:48:32 -0400 [thread overview]
Message-ID: <20080410064832.GA24941@infradead.org> (raw)
In-Reply-To: <20080410031405.GR108924158@sgi.com>
On Thu, Apr 10, 2008 at 01:14:05PM +1000, David Chinner wrote:
> On success, we still need to join the inode to the current
> transaction in xfs_itruncate_finish(). Fixes regression from
> error handling changes.
>
> Note that this does some comment reformatting (to wrap at
> 80 columns) for comments that were modified.
The fix looks good to me, and makes xfsqa survive a little longer.
It now fails in xfs_alloc_ag_vextent/xfs_alloc_ag_vextent_near/
xfs_alloc_fix_len. I suspect your next patch fixes that, but while
already commited it's unfortunately not in public CVS yet..
prev parent reply other threads:[~2008-04-10 6:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 3:14 [patch] ensure inodes are joined in xfs_itruncate_finish David Chinner
2008-04-10 6:48 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080410064832.GA24941@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox