From: David Chinner <dgc@sgi.com>
To: xfs-dev <xfs-dev@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: [patch] xfsqa - 166 - fix filter for stripe aligned filesystems
Date: Fri, 11 Apr 2008 13:36:28 +1000 [thread overview]
Message-ID: <20080411033628.GN103491721@sgi.com> (raw)
Flags has extra bits set in it xfs_bmap output when
the filesyste is using stripe alignment. Fix the test
to only look at the unwritten flag. Capture the xfs_bmap
output as well so failures can be debugged easily.
Signed-off-by: Dave Chinner <dgc@sgi.com>
---
xfstests/166 | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
Index: xfs-cmds/xfstests/166
===================================================================
--- xfs-cmds.orig/xfstests/166 2008-03-25 15:29:35.000000000 +1100
+++ xfs-cmds/xfstests/166 2008-04-11 13:33:31.220068950 +1000
@@ -17,6 +17,7 @@ here=`pwd`
tmp=/tmp/$$
status=1 # failure is the default!
trap "_cleanup; exit \$status" 0 1 2 3 15
+rm $seq.full
_cleanup()
{
@@ -39,9 +40,14 @@ _filter_blocks()
unwritten2 = ((1048576/512) / 2) - 2 * written_size
}
- if ($7) {
- size = "RIGHT"
- flags = "GOOD"
+ /* is the extent unwritten? */
+ unwritten_ext = 0;
+ if ($7 >= 10000)
+ unwritten_ext = 1;
+
+ size = "RIGHT"
+ flags = "GOOD"
+ if (unwritten_ext) {
if (unwritten1) {
if ($6 != unwritten1)
size = "WRONG"
@@ -49,11 +55,7 @@ _filter_blocks()
} else if ($6 != unwritten2) {
size = "WRONG"
}
- if ($7 < 10000)
- flags = "BAD"
} else {
- size = "RIGHT"
- flags = "GOOD"
if ($6 != written_size)
size = "WRONG"
}
@@ -77,6 +79,7 @@ FILE_SIZE=1048576
rm -f $TEST_FILE
$TEST_PROG $FILE_SIZE $TEST_FILE
+xfs_bmap -vp $TEST_FILE >> $seq.full
xfs_bmap -vp $TEST_FILE | _filter_blocks
status=0
next reply other threads:[~2008-04-11 3:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 3:36 David Chinner [this message]
2008-04-14 3:09 ` [patch] xfsqa - 166 - fix filter for stripe aligned filesystems Niv Sardi
2008-04-14 3:20 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080411033628.GN103491721@sgi.com \
--to=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox