From: Christoph Hellwig <hch@lst.de>
To: David Chinner <dgc@sgi.com>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: odd code in xfs_remove
Date: Fri, 11 Apr 2008 09:40:23 +0200 [thread overview]
Message-ID: <20080411074023.GB9236@lst.de> (raw)
In-Reply-To: <20080411023145.GK103491721@sgi.com>
On Fri, Apr 11, 2008 at 12:31:45PM +1000, David Chinner wrote:
> Looks like no harm is done by this and it's a rarely hit corner
> case, but it would appear that we should be passing in resblks in
> remove if only to avoid a potential transaction reservation
> overrun....
Okay, I'll prepare a patch and test it a little. This was the only
spurious difference between xfs_remove and xfs_rmdir left, after this
we can almost trivially merge them.
prev parent reply other threads:[~2008-04-11 7:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 18:54 odd code in xfs_remove Christoph Hellwig
2008-04-11 2:31 ` David Chinner
2008-04-11 7:40 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080411074023.GB9236@lst.de \
--to=hch@lst.de \
--cc=dgc@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox