Re: REVIEW XFSQA test out xfs_attr_shortform_bytesfit attr2/attr1 fix

[David Chinner <dgc@sgi.com>]

On Mon, Apr 14, 2008 at 11:35:36AM +1000, Timothy Shimmin wrote:
> Hi Dave and Barry,
> 
> David Chinner wrote:
> >On Wed, Apr 09, 2008 at 06:10:36PM +1000, Timothy Shimmin wrote:
> >>Hi there,
> >>
> >>A test to test out Eric's fix for xfs_attr_shortform_bytesfit
> >>bug when going from attr2 to attr1.
> >>
> >>With TOT kernel, without patch, one can see the corrupted inline
> >>dirents. With patch, all is well.
> >>
> >>The 186.out _should_ be output'ing ATTR2 for the db version
> >>command but I'm awaiting Barry's xfsprogs checkin to fix that one -
> >>and then I will regenerate it.
> >
> >Really? I'm seeing it fail with ATTR2 in the xfs_db output...
> >
> That's what I used to see until I updated to TOT kernel.
> That's weird.

It's likely due to Eric's change to make sb_badfeatures2 =
sb_features2. That will make userspace pick up the attr2 feature
properly regardless of where it is. Perhaps xfs_db is b0rked
w.r.t. reporting attr vs attr2....

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group