From: Christoph Hellwig <hch@infradead.org>
To: Barry Naujok <bnaujok@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>, xfs-dev <xfs-dev@sgi.com>
Subject: Re: [REVIEW] - cleanup xfs_attr a bit
Date: Thu, 17 Apr 2008 14:27:02 -0400 [thread overview]
Message-ID: <20080417182702.GA7154@infradead.org> (raw)
In-Reply-To: <op.t9qhhmhx3jf8g2@pc-bnaujok.melbourne.sgi.com>
On Thu, Apr 17, 2008 at 12:35:36PM +1000, Barry Naujok wrote:
> This patch starts using struct xfs_name more for the xattr code and
> is another step for using xfs_name in xfs_da_args.
>
> Also, the cred parameter is removed from xfs_attr_get and xfs_attr_fetch.
Looks good, but I'd really not expected a function called
xfs_attr_name_to_name to do the shutdown check. Either keep it in the
callers or give the function a different name.
next prev parent reply other threads:[~2008-04-17 18:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 2:35 [REVIEW] - cleanup xfs_attr a bit Barry Naujok
2008-04-17 18:27 ` Christoph Hellwig [this message]
2008-04-18 0:10 ` Barry Naujok
2008-04-18 5:11 ` Barry Naujok
2008-04-18 5:25 ` Christoph Hellwig
2008-04-18 6:23 ` Timothy Shimmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080417182702.GA7154@infradead.org \
--to=hch@infradead.org \
--cc=bnaujok@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox