From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: with ECARTIS (v1.0.0; list xfs); Wed, 23 Apr 2008 23:58:03 -0700 (PDT) Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with SMTP id m3O6vg96022638 for ; Wed, 23 Apr 2008 23:57:44 -0700 Date: Thu, 24 Apr 2008 16:58:22 +1000 From: David Chinner Subject: Re: [PATCH, XFSQA] Don't run 175-177 if DMAPI is not supported Message-ID: <20080424065822.GY103491721@sgi.com> References: <20080423013802.GJ103491721@sgi.com> <480EDE04.5080003@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <480EDE04.5080003@sgi.com> Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com List-Id: xfs To: Timothy Shimmin Cc: David Chinner , xfs-dev , xfs-oss On Wed, Apr 23, 2008 at 04:58:12PM +1000, Timothy Shimmin wrote: > Hi, > > _test_punch already does a umount $SCRATCH_MNT. > However, IMHO, it would probably be nicer if one could > use a _require_dmapi or really it may be simpler if > we could roll it into common.dmapi > so one just needs to include common.dmapi and > it would complain at that point if the kernel > didn't support it. Sure, but we don't have that, and I'm not about to spend the time to convert >20 tests to something like this. Right now I just want to remove all the bloody silly test failures on mainline kernels. All the other dmapi tests "not run" just fine, I want these to do the same thing. Is that good enough to check in right now? Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group