Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()

Christoph Hellwig
2008-04-26T20:23:03Z

On Sat, Apr 26, 2008 at 10:26:30PM +0200, Andi Kleen wrote:
> > STATIC as defined by xfs already does this..
>
> Weird. Unexpected. Different from everyone else. Is this some exercise in
> obfuscation?

The whole STATIC thing is weird to start with..

Yes, it's kinda unexpected and at least I don't particularly liked it.
But the inlining of functions with -funit-at-a-time was such a problem
for the stack useage in XFS that it got added as least horrible bandaid.