Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()

Christoph Hellwig
2008-04-26T20:06:41Z

On Sat, Apr 26, 2008 at 10:02:17PM +0200, Andi Kleen wrote:
> Denys Vlasenko <vda.linux@googlemail.com> writes:
> >
> > Compile tested only.
>
> You should mark the helper noinline just to prevent gcc from possibly
> inlining it. Even if it doesn't with your current compiler inline heuristics
> vary widely between compiler versions.

STATIC as defined by xfs already does this..