From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Denys Vlasenko <vda.linux@googlemail.com>,
xfs@oss.sgi.com, Eric Sandeen <sandeen@sandeen.net>,
Adrian Bunk <bunk@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: reduce stack usage in xfs_page_state_convert()
Date: Sun, 27 Apr 2008 23:50:23 -0400 [thread overview]
Message-ID: <20080428035023.GA14275@infradead.org> (raw)
In-Reply-To: <20080427232317.GB103491721@sgi.com>
On Mon, Apr 28, 2008 at 09:23:17AM +1000, David Chinner wrote:
> No. That code is complex enough with only one copy of it around. I don't
> want two copies that differ subtly and hence have two different sets
> of nasty, rarely hit corner cases in them.
Actually the split makes some sense. I had a ready patch to split out
releasepage which makes the whole code a lot nicer. I didn't go forward
with it because I had this idea that it would get replaced by Chris
extent_map stuff ASAP..
next prev parent reply other threads:[~2008-04-28 3:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 0:46 [PATCH] xfs: reduce stack usage in xfs_page_state_convert() Denys Vlasenko
2008-04-27 23:23 ` David Chinner
2008-04-27 23:48 ` Denys Vlasenko
2008-04-28 2:37 ` David Chinner
2008-04-28 3:51 ` Christoph Hellwig
2008-04-28 3:50 ` Christoph Hellwig [this message]
2008-04-28 22:22 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428035023.GA14275@infradead.org \
--to=hch@infradead.org \
--cc=bunk@kernel.org \
--cc=dgc@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=vda.linux@googlemail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox