From: Christoph Hellwig <hch@infradead.org>
To: Takashi Sato <t-sato@yk.jp.nec.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-ext4@vger.kernel.org, xfs@oss.sgi.com, dm-devel@redhat.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/3] Implement generic freeze feature
Date: Mon, 28 Apr 2008 09:03:58 -0400 [thread overview]
Message-ID: <20080428130358.GB2798@infradead.org> (raw)
In-Reply-To: <2E042A67F72447F6AAA0CC0605DBFA84@nsl.ad.nec.co.jp>
On Mon, Apr 28, 2008 at 09:59:55PM +0900, Takashi Sato wrote:
>> I think the protection against double freezes would be better done by
>> using a trylock on bd_mount_sem.
>
> bd_mount_sem can protect against only freezes and cannot protect against
> unfreezes. If multiple unfreezes run in parallel, the multiple up() for
> bd_mount_sem might occur incorrectly.
Indeed. The bit flag would fix that because unfreeze could then check
for the bit beeing set first. So that's probably the easiest way to go.
next prev parent reply other threads:[~2008-04-28 13:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 10:31 [RFC PATCH 1/3] Implement generic freeze feature Takashi Sato
2008-04-28 10:37 ` Christoph Hellwig
2008-04-28 12:59 ` Takashi Sato
2008-04-28 13:03 ` Christoph Hellwig [this message]
2008-04-30 1:10 ` Takashi Sato
-- strict thread matches above, loose matches on Subject: below --
2008-05-22 8:50 Takashi Sato
2008-05-25 19:32 ` Christoph Hellwig
2008-05-27 10:20 ` Takashi Sato
2008-05-14 8:06 Takashi Sato
2008-05-20 3:57 ` Andreas Dilger
2008-05-21 1:23 ` Takashi Sato
2008-04-01 12:17 Takashi Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428130358.GB2798@infradead.org \
--to=hch@infradead.org \
--cc=dm-devel@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=t-sato@yk.jp.nec.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox