From: Christoph Hellwig <hch@infradead.org>
To: Timothy Shimmin <tes@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: review: s/i_flags_lock/i_inner_lock/g
Date: Tue, 29 Apr 2008 01:37:57 -0400 [thread overview]
Message-ID: <20080429053757.GA30708@infradead.org> (raw)
In-Reply-To: <4816AEEB.8090907@sgi.com>
On Tue, Apr 29, 2008 at 03:15:23PM +1000, Timothy Shimmin wrote:
> Hi there,
>
> As part of future plans to cache incore versions of acls
> off the inode, we want to protect its modification by a spin lock.
> Dave suggested that we use the i_flags_lock but rename it to
> reflect its more general purpose on other fields, such as "i_inner_lock".
> This patch is then basically s/i_flags_lock/i_inner_lock/g.
Not too happpy about that, as I'd rather kill this lock in it's current
form and use atomic bitops on the flags. I'd rather use i_lock in the
Linux inode for the ACLs.
next prev parent reply other threads:[~2008-04-29 5:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 5:15 review: s/i_flags_lock/i_inner_lock/g Timothy Shimmin
2008-04-29 5:37 ` Christoph Hellwig [this message]
2008-04-29 21:29 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429053757.GA30708@infradead.org \
--to=hch@infradead.org \
--cc=tes@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox