Re: [PATCH] Fix non-debug build for random32() use

Lachlan McIlroy
2008-04-30T07:12:10Z

Looks good to me.

David Chinner wrote:
> Include linux/random.h in all builds, not just debug.
>
> Signed-off-by: Dave Chinner <dgc@sgi.com>
> ---
> fs/xfs/linux-2.6/xfs_linux.h | 1 +
> fs/xfs/support/debug.h | 2 --
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_linux.h
> ===================================================================
> --- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_linux.h 2008-04-22 15:06:11.000000000 +1000
> +++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_linux.h 2008-04-30 16:38:38.754688626 +1000
> @@ -75,6 +75,7 @@
> #include <linux/delay.h>
> #include <linux/log2.h>
> #include <linux/spinlock.h>
> +#include <linux/random.h>
>
> #include <asm/page.h>
> #include <asm/div64.h>
> Index: 2.6.x-xfs-new/fs/xfs/support/debug.h
> ===================================================================
> --- 2.6.x-xfs-new.orig/fs/xfs/support/debug.h 2007-08-02 22:13:10.000000000 +1000
> +++ 2.6.x-xfs-new/fs/xfs/support/debug.h 2008-04-30 16:38:43.518080606 +1000
> @@ -49,8 +49,6 @@ extern void assfail(char *expr, char *f,
>
> #else /* DEBUG */
>
> -#include <linux/random.h>
> -
> #define ASSERT(expr) \
> (unlikely(expr) ? (void)0 : assfail(#expr, __FILE__, __LINE__))
>
>