Re: [PATCH] Remove l_flushsema

David Chinner
2008-05-01T01:19:10Z

On Wed, Apr 30, 2008 at 09:17:14AM -0600, Matthew Wilcox wrote:
> On Wed, Apr 30, 2008 at 07:37:53AM -0400, Christoph Hellwig wrote:
> > On Wed, Apr 30, 2008 at 09:34:18PM +1000, David Chinner wrote:
> > > > probably loose some arguments).
> > >
> > > Yep, much cleaner. Who's signoff goes on this?
> >
> > You can have mine:
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > but I think it's till essentially willy's and he should be credited for
> > it.
>
> I'm fine with adding my S-o-B to this version:
>
> Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
>
> Here's a little twist on the idea to avoid the thundering herd.
> A vigorous review of this might not be a bad idea -- the idea is to only
> wake up sleeping processes when there seems to be enough space in the
> log to make it worthwhile. So there's a few places where we unlock the
> l_icloglock and jump back to restart; I didn't add an sv_signal there.
> But there should be an sv_signal before each exit from the function,
> and I think I've done that.

That might work. I'll have to look at it more detail later and do
some performance testing when I'm not so busy with other stuff.

FWIW, in all the error or shutdown cases, it may as well be a broadcast
as every subsequent process through this code will get the same error.
i.e. once a log error occurs, the filesystem gets shut down....

Cheers,

Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group