Re: [PATCH] Remove l_flushsema

David Chinner
2008-04-30T11:34:16Z

On Wed, Apr 30, 2008 at 07:15:21AM -0400, Christoph Hellwig wrote:
> On Wed, Apr 30, 2008 at 09:11:54PM +1000, David Chinner wrote:
> > > waitqueues are loked internally and don't need synchronization. With
> > > a little bit of re-arranging the code the wake_up could probably be
> > > moved out of the critical section.
> >
> > Yeah, I just realised that myself and was about to reply as such....
> >
> > I'll move the wakeup outside the lock.
>
> Below is the version I have now. One of the rare cases where using
> sv_t actually cleans up the code (althoug the whole sv_ family should
> probably loose some arguments).

Yep, much cleaner. Who's signoff goes on this?

Cheers,

Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group