From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Don't allow memory reclaim to wait on the filesystem in inode writeback
Date: Thu, 1 May 2008 09:15:21 -0400 [thread overview]
Message-ID: <20080501131521.GA7435@infradead.org> (raw)
In-Reply-To: <20080501122611.GK108924158@sgi.com>
On Thu, May 01, 2008 at 10:26:11PM +1000, David Chinner wrote:
> Index: 2.6.x-xfs-new/fs/xfs/xfs_inode.c
> ===================================================================
> --- 2.6.x-xfs-new.orig/fs/xfs/xfs_inode.c 2008-04-28 16:35:23.000000000 +1000
> +++ 2.6.x-xfs-new/fs/xfs/xfs_inode.c 2008-05-01 20:04:55.151880341 +1000
> @@ -2986,7 +2986,7 @@ xfs_iflush_cluster(
> ASSERT(pag->pag_ici_init);
>
> ilist_size = XFS_INODE_CLUSTER_SIZE(mp) * sizeof(xfs_inode_t *);
> - ilist = kmem_alloc(ilist_size, KM_MAYFAIL);
> + ilist = kmem_alloc(ilist_size, KM_NOFS);
> if (!ilist)
> return 0;
This should be KM_MAYFAIL | KM_NOFS, because KM_NOFS doesn't imply that
the allocation may fail.
next prev parent reply other threads:[~2008-05-01 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 12:26 [PATCH] Don't allow memory reclaim to wait on the filesystem in inode writeback David Chinner
2008-05-01 13:15 ` Christoph Hellwig [this message]
2008-05-01 22:08 ` David Chinner
2008-05-01 22:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080501131521.GA7435@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox