From: Christoph Hellwig <hch@lst.de>
To: xfs@oss.sgi.com
Subject: [PATCH 3/10] don't call xfs_freesb from xfs_mountfs failure case
Date: Fri, 2 May 2008 00:01:00 +0200 [thread overview]
Message-ID: <20080501220100.GC2315@lst.de> (raw)
Freeing of the superblock is already handled in the caller, and that
is more symmetric with the mount path, too.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6-xfs/fs/xfs/xfs_mount.c
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/xfs_mount.c 2008-05-01 21:20:47.000000000 +0200
+++ linux-2.6-xfs/fs/xfs/xfs_mount.c 2008-05-01 21:21:04.000000000 +0200
@@ -1272,7 +1272,6 @@ xfs_mountfs(
error1:
if (uuid_mounted)
uuid_table_remove(&mp->m_sb.sb_uuid);
- xfs_freesb(mp);
return error;
}
reply other threads:[~2008-05-01 22:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080501220100.GC2315@lst.de \
--to=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox