From: Christoph Hellwig <hch@lst.de>
To: xfs@oss.sgi.com
Subject: [PATCH 8/10] kill calls to xfs_binval in the mount error path
Date: Fri, 2 May 2008 00:01:24 +0200 [thread overview]
Message-ID: <20080501220124.GH2315@lst.de> (raw)
xfs_binval aka xfs_flush_buftarg is the first thing done in
xfs_free_buftarg, so there is no need to have duplicated calls just
before xfs_free_buftarg in the mount failure path.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_super.c 2008-05-01 20:33:11.000000000 +0200
+++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c 2008-05-01 20:33:35.000000000 +0200
@@ -1790,10 +1790,10 @@ xfs_fs_fill_super(
*/
error = xfs_start_flags(args, mp);
if (error)
- goto error1;
+ goto out_destroy_counters;
error = xfs_readsb(mp, flags);
if (error)
- goto error1;
+ goto out_destroy_counters;
error = xfs_finish_flags(args, mp);
if (error)
goto error2;
@@ -1854,12 +1854,6 @@ xfs_fs_fill_super(
error2:
if (mp->m_sb_bp)
xfs_freesb(mp);
- error1:
- xfs_binval(mp->m_ddev_targp);
- if (mp->m_logdev_targp && mp->m_logdev_targp != mp->m_ddev_targp)
- xfs_binval(mp->m_logdev_targp);
- if (mp->m_rtdev_targp)
- xfs_binval(mp->m_rtdev_targp);
out_destroy_counters:
xfs_icsb_destroy_counters(mp);
xfs_close_devices(mp);
reply other threads:[~2008-05-01 22:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080501220124.GH2315@lst.de \
--to=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox