From: Christoph Hellwig <hch@infradead.org>
To: xaiki@sgi.com
Cc: xfs-dev@sgi.com, xfs@oss.sgi.com
Subject: Re: Don't use d_alloc_anon for open_by_handle
Date: Fri, 2 May 2008 02:06:54 -0400 [thread overview]
Message-ID: <20080502060654.GA23912@infradead.org> (raw)
In-Reply-To: <1209693339-4861-1-git-send-email-xaiki@sgi.com>
On Fri, May 02, 2008 at 11:55:37AM +1000, xaiki@sgi.com wrote:
> One of our DMAPI user found that in some cases inodes weren't getting through
> xfs_inactive() in any reasonable amount of time. Investigation tracked it down
> to the use of d_alloc_anon() combined with another thread accessing the same
> inode via an open().
>
> So we introduce a stripped down version of d_alloc_anon, that won't try to find
> an existing dentry, nor will hash it.
No, this is even more buggy than using d_alloc_anon. What really needs
to be done in the handle code is to do the full reconnect logic nfsd
would be doing. Aka you should be using exportfs_decode_fh and update
xfs's fh_to_dentry method to accept the file handle type used by the
handle interface.
next prev parent reply other threads:[~2008-05-02 6:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080501070244.GH108924158@sgi.com>
2008-05-02 1:55 ` Don't use d_alloc_anon for open_by_handle xaiki
2008-05-02 1:55 ` [PATCH] Don't use hashed dentries when doing open_by_handle xaiki
2008-05-02 1:55 ` [PATCH] Use xfs_d_alloc_anon for DM rdwr using handle code xaiki
2008-05-02 6:06 ` Christoph Hellwig [this message]
2008-05-05 6:33 ` Don't use d_alloc_anon for open_by_handle Niv Sardi
2008-05-05 9:53 ` Christoph Hellwig
2008-05-05 18:44 ` Christoph Hellwig
2008-05-05 20:51 ` Greg Banks
2008-05-06 1:38 ` Niv Sardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080502060654.GA23912@infradead.org \
--to=hch@infradead.org \
--cc=xaiki@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox