From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Fix xfs_fsync() b0rkage
Date: Tue, 6 May 2008 01:19:16 -0400 [thread overview]
Message-ID: <20080506051916.GA7402@infradead.org> (raw)
In-Reply-To: <20080506022701.GN155679365@sgi.com>
On Tue, May 06, 2008 at 12:27:01PM +1000, David Chinner wrote:
> Fix fsync() b0rkage.
>
> xfs_fsync() fails to wait for data I/O completion before checking if
> the inode is dirty or clean to decide whether to log the inode or not.
> This misses inode size updates when the data flushed by the fsync()
> is extending the file. This results in xfsqa test 179 failures.
>
> Hence, like fdatasync(), we need to wait for I/O completion first,
> then check the inode for cleanliness. Doing so makes the behaviour of
> xfs_fsync() identical for fsync and fdatasync and we *always* use
> synchronous semantics if the inode is dirty. Therefore also kill the
> differences and remove the unused flags from the xfs_fsync function
> and callers.
The change looks good from a quick look, but while you're at it you
can also remove the unused start/stop arguments.
next prev parent reply other threads:[~2008-05-06 5:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-06 2:27 [PATCH] Fix xfs_fsync() b0rkage David Chinner
2008-05-06 5:19 ` Christoph Hellwig [this message]
2008-05-06 5:50 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506051916.GA7402@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox