From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/10] merge xfs_unmount into xfs_fs_put_super / xfs_fs_fill_super
Date: Mon, 12 May 2008 01:43:27 -0400 [thread overview]
Message-ID: <20080512054327.GA26038@infradead.org> (raw)
In-Reply-To: <20080512022138.GX155679365@sgi.com>
On Mon, May 12, 2008 at 12:21:38PM +1000, David Chinner wrote:
> > + if (mp->m_flags & XFS_MOUNT_DMAPI) {
> > + XFS_SEND_UNMOUNT(mp, rip, DM_RIGHT_NULL, 0, 0,
> > + unmount_event_flags);
> > + }
>
> #ifdef HAVE_DMAPI around this chunk? I know the old code didn't,
> but it would then match the pre-unmount event hunk above...
We don't have #ifdefs around the other dmapi namespace bits. In fact
I'd prefer to kill the one above aswell. It's on my todo list because
I wan't to prove that using the normal event enabled macros are safe
in the unmount path first and just switch to those.
prev parent reply other threads:[~2008-05-12 5:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 22:00 [PATCH 1/10] merge xfs_unmount into xfs_fs_put_super / xfs_fs_fill_super Christoph Hellwig
2008-05-09 6:31 ` Christoph Hellwig
2008-05-12 1:43 ` David Chinner
2008-05-12 2:21 ` David Chinner
2008-05-12 5:43 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512054327.GA26038@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox