From: David Chinner <dgc@sgi.com>
To: tes@sgi.com
Cc: xfs-dev@sgi.com, xfs@oss.sgi.com
Subject: Re: review: log_filter.patch 018,081,082 pv#981362
Date: Mon, 12 May 2008 16:41:15 +1000 [thread overview]
Message-ID: <20080512064115.GF155679365@sgi.com> (raw)
In-Reply-To: <48227ef3.WIWE0hYubr4nS8cD%tes@sgi.com>
On Thu, May 08, 2008 at 02:17:55PM +1000, tes@sgi.com wrote:
> Due to the changes for default mkfs options where we now have
> version 2 inodes, we no longer update the di_onlink field.
> To be consistent with previous output, we filter these values out.
> Also, as part of changes to the inode generation number which uses
> a random num generator, we need to filter out the gen# too.
>
> --Tim
>
> 018.op.irix | 400 +++++++++++------------
> 018.op.linux | 400 +++++++++++------------
> 018.trans_inode | 800 +++++++++++++++++++++++------------------------
> 081.ugquota.trans_inode | 816 ++++++++++++++++++++++++------------------------
> 082.op.irix | 400 +++++++++++------------
> 082.op.linux | 400 +++++++++++------------
> 082.trans_inode | 800 +++++++++++++++++++++++------------------------
> common.log | 3
> 8 files changed, 2011 insertions(+), 2008 deletions(-)
Worth noting is that these tests all still fail on a config that
corrects a problem with the superblock features2 field on mount.
Probably not worth bothering about - but I thought I'd mention it
as updating the tests didn't fix the failure on my machine. Updating
xfsprogs now....
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next parent reply other threads:[~2008-05-12 6:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48227ef3.WIWE0hYubr4nS8cD%tes@sgi.com>
2008-05-12 6:41 ` David Chinner [this message]
2008-05-12 6:47 ` review: log_filter.patch 018,081,082 pv#981362 Timothy Shimmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512064115.GF155679365@sgi.com \
--to=dgc@sgi.com \
--cc=tes@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox