public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: xfs@oss.sgi.com
Subject: [PATCH] don't run test 167 if killall is not installed
Date: Thu, 15 May 2008 07:39:18 +0200	[thread overview]
Message-ID: <20080515053918.GA16530@lst.de> (raw)

Test 167 will leave runaway fsstress processes around in case killall is
not installed and thus make all following tests fail.  This patch checks
for killall beeing installed and error out otherwise.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: xfstests/167
===================================================================
RCS file: /cvs/xfs-cmds/xfstests/167,v
retrieving revision 1.3
diff -u -p -r1.3 167
--- xfstests/167	2 Aug 2007 16:19:56 -0000	1.3
+++ xfstests/167	15 May 2008 05:34:20 -0000
@@ -13,6 +13,7 @@ owner=dgc@sgi.com
 seq=`basename $0`
 echo "QA output created by $seq"
 
+killall="/usr/bin/killall"
 here=`pwd`
 tmp=/tmp/$$
 rm -f $seq.full
@@ -43,6 +44,8 @@ workout()
 _supported_fs xfs
 _supported_os Linux
 
+[ -x $killall ] || _notrun "$killall executable not found"
+
 _setup_testdir
 _require_scratch
 _scratch_mkfs_xfs >/dev/null 2>&1

             reply	other threads:[~2008-05-15  5:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-15  5:39 Christoph Hellwig [this message]
2008-05-15  6:40 ` [PATCH] don't run test 167 if killall is not installed Tim Shimmin
2008-05-15  7:13   ` Christoph Hellwig
2008-05-15  7:36     ` David Chinner
2008-05-15  7:38       ` Christoph Hellwig
2008-05-19  1:45         ` Timothy Shimmin
2008-05-15  6:40 ` David Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080515053918.GA16530@lst.de \
    --to=hch@lst.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox