From: David Chinner <dgc@sgi.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Tim Shimmin <tes@sgi.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] don't run test 167 if killall is not installed
Date: Thu, 15 May 2008 17:36:05 +1000 [thread overview]
Message-ID: <20080515073605.GR155679365@sgi.com> (raw)
In-Reply-To: <20080515071338.GA26247@lst.de>
On Thu, May 15, 2008 at 09:13:38AM +0200, Christoph Hellwig wrote:
> On Thu, May 15, 2008 at 04:40:01PM +1000, Tim Shimmin wrote:
> > Looks reasonable.
> >
> > However:
> >
> > * could use set_prog_path like we do in common.config.
> >
> > * I wonder if one could use "kill -$pgid" on the process group
> > for fsstress instead of killall (I've never tried it :).
>
> Dave already commited the original version, but I'll send an update
> to use set_prog_path later today.
Sorry, didn't see that Tim replied as well. set_prog_path is fine
by me too, but stopping every test from running because killall is
not present is a bit of overkill, isn't it?
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2008-05-15 7:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 5:39 [PATCH] don't run test 167 if killall is not installed Christoph Hellwig
2008-05-15 6:40 ` Tim Shimmin
2008-05-15 7:13 ` Christoph Hellwig
2008-05-15 7:36 ` David Chinner [this message]
2008-05-15 7:38 ` Christoph Hellwig
2008-05-19 1:45 ` Timothy Shimmin
2008-05-15 6:40 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515073605.GR155679365@sgi.com \
--to=dgc@sgi.com \
--cc=hch@lst.de \
--cc=tes@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox