From: Christoph Hellwig <hch@lst.de>
To: xfs@oss.sgi.com
Subject: [PATCH] fix reiserfs case in 032
Date: Thu, 15 May 2008 19:05:05 +0200 [thread overview]
Message-ID: <20080515170505.GA8949@lst.de> (raw)
mkfs.reiserfs refuses to create a filesystem on full devices without
partitions unless it's given -f in addition to the already required Y
input to confirm the fs creation, so give the argument to it.
While we're at it also write the full command line used to create the
filesystem into the log to ease future debugging.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfstests/032
===================================================================
RCS file: /cvs/xfs-cmds/xfstests/032,v
retrieving revision 1.13
diff -u -p -r1.13 032
--- xfstests/032 9 Nov 2005 02:49:08 -0000 1.13
+++ xfstests/032 15 May 2008 17:02:08 -0000
@@ -43,7 +43,7 @@ do
[ $fs = vfat ] && postargs=2000
# these folks prompt before writing
[ $fs = jfs ] && preop="echo Y |"
- [ $fs = reiserfs ] && preop="echo y |"
+ [ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
# cramfs mkfs requires a directory argument
[ $fs = cramfs ] && preargs=/proc/fs/xfs
@@ -52,7 +52,7 @@ do
# create a filesystem of this type
echo "=== Creating $fs filesystem..." >>$seq.full
- echo " ( mkfs -t $fs $SCRATCH_DEV )" >>$seq.full
+ echo " ( $preop mkfs -t $fs $preargs $SCRATCH_DEV $postargs )" >>$seq.full
eval $preop mkfs -t $fs $preargs $SCRATCH_DEV $postargs >>$seq.full 2>&1
# next, ensure we don't overwrite it
next reply other threads:[~2008-05-15 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 17:05 Christoph Hellwig [this message]
2008-05-21 8:15 ` [PATCH] fix reiserfs case in 032 Christoph Hellwig
2008-05-28 13:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515170505.GA8949@lst.de \
--to=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox