From: Christoph Hellwig <hch@lst.de>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] kill xfs_uuid_unmount
Date: Fri, 16 May 2008 09:22:51 +0200 [thread overview]
Message-ID: <20080516072251.GB1052@lst.de> (raw)
In-Reply-To: <20080426200923.GA14172@lst.de>
On Sat, Apr 26, 2008 at 10:09:23PM +0200, Christoph Hellwig wrote:
> Quite useless wrapper that doesn't help making the code more readable.
ping?
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6-xfs/fs/xfs/xfs_mount.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/xfs_mount.c 2008-04-25 20:40:50.000000000 +0200
> +++ linux-2.6-xfs/fs/xfs/xfs_mount.c 2008-04-25 20:48:27.000000000 +0200
> @@ -47,7 +47,6 @@
>
> STATIC int xfs_mount_log_sb(xfs_mount_t *, __int64_t);
> STATIC int xfs_uuid_mount(xfs_mount_t *);
> -STATIC void xfs_uuid_unmount(xfs_mount_t *mp);
> STATIC void xfs_unmountfs_wait(xfs_mount_t *);
>
>
> @@ -1262,7 +1261,7 @@ xfs_mountfs(
> /* FALLTHROUGH */
> error1:
> if (uuid_mounted)
> - xfs_uuid_unmount(mp);
> + uuid_table_remove(&mp->m_sb.sb_uuid);
> xfs_freesb(mp);
> return error;
> }
> @@ -1343,7 +1342,7 @@ xfs_unmountfs(xfs_mount_t *mp, struct cr
>
> xfs_unmountfs_close(mp, cr);
> if ((mp->m_flags & XFS_MOUNT_NOUUID) == 0)
> - xfs_uuid_unmount(mp);
> + uuid_table_remove(&mp->m_sb.sb_uuid);
>
> #if defined(DEBUG) || defined(INDUCE_IO_ERROR)
> xfs_errortag_clearall(mp, 0);
> @@ -1905,16 +1904,6 @@ xfs_uuid_mount(
> }
>
> /*
> - * Remove filesystem from the UUID table.
> - */
> -STATIC void
> -xfs_uuid_unmount(
> - xfs_mount_t *mp)
> -{
> - uuid_table_remove(&mp->m_sb.sb_uuid);
> -}
> -
> -/*
> * Used to log changes to the superblock unit and width fields which could
> * be altered by the mount options, as well as any potential sb_features2
> * fixup. Only the first superblock is updated.
---end quoted text---
prev parent reply other threads:[~2008-05-16 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 20:09 [PATCH] kill xfs_uuid_unmount Christoph Hellwig
2008-05-16 7:22 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080516072251.GB1052@lst.de \
--to=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox