From: Christoph Hellwig <hch@lst.de>
To: Niv Sardi <xaiki@sgi.com>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH] streamline init/exit path
Date: Wed, 21 May 2008 08:01:03 +0200 [thread overview]
Message-ID: <20080521060103.GA25003@lst.de> (raw)
In-Reply-To: <nccprrg32vr.fsf@sgi.com>
On Wed, May 21, 2008 at 10:41:12AM +1000, Niv Sardi wrote:
> Looks good, appart from the fact that I don't see the point of merging
> xfs_{init,destroy}_zones into xfs_{init,exit}, appart from clobbering it
> and making it less readeable.
>
> could be:
> error = xfs_init_zones();
> if (error)
> goto out;
>
> and all the other error cases will end with
> xfs_destroy_zones();
>
> That would look much more like the rest of the calls in these functions.
I don't really see the point for splitting this up, it's not like it
makes the initialization much simpler. But hey, if that's the only
objection I can changed it.
At least someone is looking at my xfs patches :)
next prev parent reply other threads:[~2008-05-21 6:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-18 13:05 [PATCH] streamline init/exit path Christoph Hellwig
2008-05-21 0:41 ` Niv Sardi
2008-05-21 6:01 ` Christoph Hellwig [this message]
2008-05-21 7:01 ` Niv Sardi
2008-05-21 7:24 ` Christoph Hellwig
2008-05-21 8:11 ` TAKE " Niv Sardi
2008-05-22 15:56 ` Christoph Hellwig
2008-05-23 0:26 ` Barry Naujok
2008-05-23 1:57 ` Niv Sardi
2008-05-25 19:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521060103.GA25003@lst.de \
--to=hch@lst.de \
--cc=xaiki@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox