From: Christoph Hellwig <hch@infradead.org>
To: Barry Naujok <bnaujok@sgi.com>
Cc: sgi.bugs.xfs@engr.sgi.com, xfs@oss.sgi.com
Subject: Re: TAKE 981521 - Return actual name for CI match for dentry cache
Date: Wed, 21 May 2008 03:36:25 -0400 [thread overview]
Message-ID: <20080521073625.GA26580@infradead.org> (raw)
In-Reply-To: <20080521034449.67F4758C4C29@chook.melbourne.sgi.com>
On Wed, May 21, 2008 at 01:44:49PM +1000, Barry Naujok wrote:
> Return case-insensitive match for dentry cache
>
> This implements the code to store the actual filename found
> during a lookup in the dentry cache and to avoid multiple entries
> in the dcache pointing to the same inode.
>
> To avoid polluting the dcache, we implement a new directory inode
> operations for lookup. xfs_vn_ci_lookup() stores the correct case
> name in the dcache.
>
> The "actual name" is only allocated and returned for a case-
> insensitive match and not an actual match.
>
> Another unusual interaction with the dcache is not storing
> negative dentries like other filesystems doing a d_add(dentry, NULL)
> when an ENOENT is returned. During the VFS lookup, if a dentry
> returned has no inode, dput is called and ENOENT is returned.
> By not doing a d_add, this actually removes it completely from
> the dcache to be reused. create/rename have to be modified to
> support unhashed dentries being passed in.
This requires the d_add_ci helper which doesn't exist in the CVS on oss.
next prev parent reply other threads:[~2008-05-21 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 3:44 TAKE 981521 - Return actual name for CI match for dentry cache Barry Naujok
2008-05-21 7:36 ` Christoph Hellwig [this message]
2008-05-21 7:40 ` Barry Naujok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521073625.GA26580@infradead.org \
--to=hch@infradead.org \
--cc=bnaujok@sgi.com \
--cc=sgi.bugs.xfs@engr.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox