From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [patch] remove xattr buffer size dependency on page size in xfsdump
Date: Thu, 22 May 2008 09:28:41 -0400 [thread overview]
Message-ID: <20080522132841.GD4972@infradead.org> (raw)
In-Reply-To: <20080522061402.GS173056135@sgi.com>
On Thu, May 22, 2008 at 04:14:02PM +1000, David Chinner wrote:
>
> The extended attr buffer size used by xfsdump is based on page size.
> The maximum buffer size the kernel will accept is 64k. On a 64k page
> machine, the default buffer size will be rejected by the kernel, thereby
> breaking dump and restore.
>
> Limit the buffer size to XATTR_LIST_MAX in dump, restore and libhandle
> so the kernel won't reject otherwise valid requests.
I suspect this will break on non-linux platforms because XATTR_LIST_MAX
is only in the Linux headers. With a precaution, e.g. by keeping the
old behaviour when XATTR_LIST_MAX is not defined this looks good.
prev parent reply other threads:[~2008-05-22 13:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 6:14 [patch] remove xattr buffer size dependency on page size in xfsdump David Chinner
2008-05-22 13:28 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080522132841.GD4972@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox