Re: [PATCH 4/4] fix biosize option

Christoph Hellwig
2008-08-28T23:17:44Z

ping^2?

On Wed, Jul 23, 2008 at 10:05:20AM +0200, Christoph Hellwig wrote:
> ping?
>
> On Sun, May 25, 2008 at 09:07:54PM +0200, Christoph Hellwig wrote:
> > iosizelog shouldn't be the same as iosize but the logarithm of it. Then
> > again the current biosize option doesn't make much sense to me as it
> > doesn't set the preferred I/O size as mentioned in the comment next to
> > it but rather the allocation size and thus is identical to the allocsize
> > option (except for the missing logarithm). It's also not documented in
> > Documentation/filesystems/xfs.txt or the mount manpage.
> >
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c
> > ===================================================================
> > --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_super.c 2008-05-25 20:59:04.000000000 +0200
> > +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c 2008-05-25 20:59:38.000000000 +0200
> > @@ -252,7 +252,7 @@ xfs_parseargs(
> > return EINVAL;
> > }
> > iosize = simple_strtoul(value, &eov, 10);
> > - iosizelog = (uint8_t) iosize;
> > + iosizelog = ffs(iosize) - 1;
> > } else if (!strcmp(this_char, MNTOPT_ALLOCSIZE)) {
> > if (!value || !*value) {
> > cmn_err(CE_WARN,
> ---end quoted text---
---end quoted text---