From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: xfs_check
Date: Wed, 28 May 2008 09:21:11 +1000 [thread overview]
Message-ID: <20080527232111.GB3819@disturbed> (raw)
In-Reply-To: <20080527162605.GA30344@lst.de>
On Tue, May 27, 2008 at 06:26:05PM +0200, Christoph Hellwig wrote:
> In the past we had quite a few cases where we told people to run
> xfs_repair -n instead of xfs_check. I think that makes a lot of sense
> because xfs_repair -n generally gives output at least as useful as
> xfs_check if not more so and also is a lot faster. Is there any reason
> why we shouldn't simply kill xfs_check and replaced it with a wrapper
> around xfs_repair?
xfs_repair doesn't yet check free space btrees - it simply
blows them away and rebuilds htem from scratch. Hence errors
in those btrees will go unreported. xfs_check will tell you
about errors in those trees.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-05-27 23:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 16:26 xfs_check Christoph Hellwig
2008-05-27 16:48 ` xfs_check Eric Sandeen
2008-05-27 16:50 ` xfs_check Chris Wedgwood
2008-05-27 16:55 ` xfs_check Eric Sandeen
2008-05-27 23:50 ` xfs_check Barry Naujok
2008-05-27 23:21 ` Dave Chinner [this message]
2008-05-27 23:49 ` xfs_check Barry Naujok
2008-05-28 8:20 ` xfs_check Emmanuel Florac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080527232111.GB3819@disturbed \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox