[PATCH] fix reiserfs case in 032

[PATCH] fix reiserfs case in 032

[Christoph Hellwig]

mkfs.reiserfs refuses to create a filesystem on full devices without
partitions unless it's given -f in addition to the already required Y
input to confirm the fs creation, so give the argument to it.

While we're at it also write the full command line used to create the
filesystem into the log to ease future debugging.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: xfstests/032
===================================================================
RCS file: /cvs/xfs-cmds/xfstests/032,v
retrieving revision 1.13
diff -u -p -r1.13 032
--- xfstests/032	9 Nov 2005 02:49:08 -0000	1.13
+++ xfstests/032	15 May 2008 17:02:08 -0000
@@ -43,7 +43,7 @@ do
 	[ $fs = vfat ] && postargs=2000
 	# these folks prompt before writing
 	[ $fs = jfs ] && preop="echo Y |"
-	[ $fs = reiserfs ] && preop="echo y |"
+	[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
 	# cramfs mkfs requires a directory argument
 	[ $fs = cramfs ] && preargs=/proc/fs/xfs
 
@@ -52,7 +52,7 @@ do
 
 	# create a filesystem of this type
 	echo "=== Creating $fs filesystem..." >>$seq.full
-	echo "    ( mkfs -t $fs $SCRATCH_DEV )" >>$seq.full
+	echo "    ( $preop mkfs -t $fs $preargs $SCRATCH_DEV $postargs )" >>$seq.full
 	eval $preop mkfs -t $fs $preargs $SCRATCH_DEV $postargs >>$seq.full 2>&1
 
 	# next, ensure we don't overwrite it

Re: [PATCH] fix reiserfs case in 032

[Christoph Hellwig]

ping?

On Thu, May 15, 2008 at 07:05:05PM +0200, Christoph Hellwig wrote:
> mkfs.reiserfs refuses to create a filesystem on full devices without
> partitions unless it's given -f in addition to the already required Y
> input to confirm the fs creation, so give the argument to it.
> 
> While we're at it also write the full command line used to create the
> filesystem into the log to ease future debugging.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: xfstests/032
> ===================================================================
> RCS file: /cvs/xfs-cmds/xfstests/032,v
> retrieving revision 1.13
> diff -u -p -r1.13 032
> --- xfstests/032	9 Nov 2005 02:49:08 -0000	1.13
> +++ xfstests/032	15 May 2008 17:02:08 -0000
> @@ -43,7 +43,7 @@ do
>  	[ $fs = vfat ] && postargs=2000
>  	# these folks prompt before writing
>  	[ $fs = jfs ] && preop="echo Y |"
> -	[ $fs = reiserfs ] && preop="echo y |"
> +	[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
>  	# cramfs mkfs requires a directory argument
>  	[ $fs = cramfs ] && preargs=/proc/fs/xfs
>  
> @@ -52,7 +52,7 @@ do
>  
>  	# create a filesystem of this type
>  	echo "=== Creating $fs filesystem..." >>$seq.full
> -	echo "    ( mkfs -t $fs $SCRATCH_DEV )" >>$seq.full
> +	echo "    ( $preop mkfs -t $fs $preargs $SCRATCH_DEV $postargs )" >>$seq.full
>  	eval $preop mkfs -t $fs $preargs $SCRATCH_DEV $postargs >>$seq.full 2>&1
>  
>  	# next, ensure we don't overwrite it
---end quoted text---

Re: [PATCH] fix reiserfs case in 032

[Christoph Hellwig]

Can we get a least a trivial testsuite fix like this reviewed an in?

On Thu, May 15, 2008 at 07:05:05PM +0200, Christoph Hellwig wrote:
> mkfs.reiserfs refuses to create a filesystem on full devices without
> partitions unless it's given -f in addition to the already required Y
> input to confirm the fs creation, so give the argument to it.
> 
> While we're at it also write the full command line used to create the
> filesystem into the log to ease future debugging.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: xfstests/032
> ===================================================================
> RCS file: /cvs/xfs-cmds/xfstests/032,v
> retrieving revision 1.13
> diff -u -p -r1.13 032
> --- xfstests/032	9 Nov 2005 02:49:08 -0000	1.13
> +++ xfstests/032	15 May 2008 17:02:08 -0000
> @@ -43,7 +43,7 @@ do
>  	[ $fs = vfat ] && postargs=2000
>  	# these folks prompt before writing
>  	[ $fs = jfs ] && preop="echo Y |"
> -	[ $fs = reiserfs ] && preop="echo y |"
> +	[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
>  	# cramfs mkfs requires a directory argument
>  	[ $fs = cramfs ] && preargs=/proc/fs/xfs
>  
> @@ -52,7 +52,7 @@ do
>  
>  	# create a filesystem of this type
>  	echo "=== Creating $fs filesystem..." >>$seq.full
> -	echo "    ( mkfs -t $fs $SCRATCH_DEV )" >>$seq.full
> +	echo "    ( $preop mkfs -t $fs $preargs $SCRATCH_DEV $postargs )" >>$seq.full
>  	eval $preop mkfs -t $fs $preargs $SCRATCH_DEV $postargs >>$seq.full 2>&1
>  
>  	# next, ensure we don't overwrite it
---end quoted text---