public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Barry Naujok <bnaujok@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [REVIEW] Invalidate dentry on unlink/rmdir if using CI mode
Date: Fri, 13 Jun 2008 06:25:55 -0400	[thread overview]
Message-ID: <20080613102555.GA1700@infradead.org> (raw)
In-Reply-To: <op.ucoa9vjb3jf8g2@pc-bnaujok.melbourne.sgi.com>

On Fri, Jun 13, 2008 at 04:06:57PM +1000, Barry Naujok wrote:
> Once of the interesting features of vfs_unlink/d_delete functionality
> is that if it's the only inode being referenced, it makes the dentry
> negative. CI doesn't work with negative dentries, so the following code
> invalidate the dentry in CI mode.

Please add a comment like this patch description near the the calls
you added, otherwise ok.

      reply	other threads:[~2008-06-13 10:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-13  6:06 [REVIEW] Invalidate dentry on unlink/rmdir if using CI mode Barry Naujok
2008-06-13 10:25 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080613102555.GA1700@infradead.org \
    --to=hch@infradead.org \
    --cc=bnaujok@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox