From: Christoph Hellwig <hch@lst.de>
To: Donald Douwsma <donaldd@sgi.com>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH] kill INDUCE_IO_ERROR
Date: Wed, 18 Jun 2008 14:05:36 +0200 [thread overview]
Message-ID: <20080618120535.GA32691@lst.de> (raw)
In-Reply-To: <485892D7.4080000@sgi.com>
On Wed, Jun 18, 2008 at 02:45:11PM +1000, Donald Douwsma wrote:
> Christoph Hellwig wrote:
> >On Fri, May 23, 2008 at 08:23:23AM +0200, Christoph Hellwig wrote:
> >>All the error injection is already enabled through ifdef DEBUG, so kill
> >>the never set second cpp symbol to activate it without the rest of the
> >>debugging infrastructure.
> >
> >Can I get a review on this absolutely trivial patch?
>
> I'd like to keep INDUCE_IO_ERROR around so we have a way to introduce
> ioerrors in release builds during testing.
>
> We could add it to xfs.h with the commented out QUOTADEBUG so people
> know we still want to use it.
cpp symbols not exposed by Kconfig will never get tested. If you thing
it's really useful for release builds (which don't quite agree with) we
should just enable it unconditionally. It's just in a few places, and
any branch predictor worth it's name should take care of the additional
branches without visible cost.
next prev parent reply other threads:[~2008-06-18 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 6:23 [PATCH] kill INDUCE_IO_ERROR Christoph Hellwig
2008-06-16 10:14 ` Christoph Hellwig
2008-06-18 4:45 ` Donald Douwsma
2008-06-18 12:05 ` Christoph Hellwig [this message]
2008-07-25 4:30 ` Niv Sardi
2008-07-25 4:32 ` Christoph Hellwig
2008-07-25 5:10 ` Donald Douwsma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080618120535.GA32691@lst.de \
--to=hch@lst.de \
--cc=donaldd@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox