From: Dave Chinner <david@fromorbit.com>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-dev <xfs-dev@sgi.com>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] Always reset btree cursor after an insert
Date: Fri, 20 Jun 2008 13:37:10 +1000 [thread overview]
Message-ID: <20080620033710.GZ3700@disturbed> (raw)
In-Reply-To: <485B0B04.80808@sgi.com>
On Fri, Jun 20, 2008 at 11:42:28AM +1000, Lachlan McIlroy wrote:
> Christoph Hellwig wrote:
>> On Thu, Jun 19, 2008 at 04:17:15PM +1000, Lachlan McIlroy wrote:
>>> After a btree insert operation a cursor can be invalid due to block
>>> splits and a maybe a new root block. We reset the cursor in
>>> xfs_bmbt_insert() in the cases where we think we need to but it
>>> isn't enough as we still see assertions. Just do what we do elsewhere
>>> and reset the cursor unconditionally. Version 2 adds
>>> XFS_WANT_CORRUPTED_GOTO checks throughout xfs_bmap.c and removes the
>>> fix to revalidate the original cursor in xfs_bmbt_insert().
>>
>> Can you commit the XFS_WANT_CORRUPTED_GOTO checks as a separate patch
>> before the cursor reset? ACK from me for those hunks.
>>
>
> Yeah, no problem, thanks.
The rest of it looks ok as well, Lachlan.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-06-20 3:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 6:17 [PATCH V2] Always reset btree cursor after an insert Lachlan McIlroy
2008-06-19 8:35 ` Christoph Hellwig
2008-06-20 1:42 ` Lachlan McIlroy
2008-06-20 3:37 ` Dave Chinner [this message]
2008-06-20 7:35 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080620033710.GZ3700@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox