From: Dave Chinner <david@fromorbit.com>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Don't assert if trying to mount with blocksize > pagesize
Date: Thu, 26 Jun 2008 13:03:15 +1000 [thread overview]
Message-ID: <20080626030315.GG11558@disturbed> (raw)
In-Reply-To: <4863056D.3080209@sgi.com>
On Thu, Jun 26, 2008 at 12:56:45PM +1000, Lachlan McIlroy wrote:
> If we don't do the blocksize/PAGESIZE check before
> calling xfs_sb_validate_fsb_count() we can assert
> if we try to mount with a blocksize > pagesize.
> The assert is valid so leave it and just move the
> blocksize/pagesize check earlier.
Yes, looks like a problem. The fix looks ok.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-06-26 3:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 2:56 [PATCH] Don't assert if trying to mount with blocksize > pagesize Lachlan McIlroy
2008-06-26 3:03 ` Dave Chinner [this message]
2008-06-26 8:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080626030315.GG11558@disturbed \
--to=david@fromorbit.com \
--cc=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox