From: Dave Chinner <david@fromorbit.com>
To: Timothy Shimmin <tes@sgi.com>
Cc: Mark Goodwin <markgw@sgi.com>,
Christoph Hellwig <hch@infradead.org>,
Lachlan McIlroy <lachlan@sgi.com>, xfs-dev <xfs-dev@sgi.com>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Fix use after free when closing log/rt devices
Date: Wed, 2 Jul 2008 12:54:54 +1000 [thread overview]
Message-ID: <20080702025454.GW29319@disturbed> (raw)
In-Reply-To: <486AE0F8.5080506@sgi.com>
On Wed, Jul 02, 2008 at 11:59:20AM +1000, Timothy Shimmin wrote:
> Christoph Hellwig wrote:
> > On Fri, Jun 27, 2008 at 04:39:39PM +1000, Mark Goodwin wrote:
> >> do we have any QA tests that test external log?
> >
> > Most QA tests will use the external log if you set it up that way. But
> > ithout slab poisoning this won't be noticed either.
>
> I think you need:
> USE_EXTERNAL=yes
> SCRATCH_LOGDEV=somelogdevice
> TEST_LOGDEV=somelogdevice
> to get the scratch and test mounts using an external log.
Yes. Typically I used to use SCRATCH_LOGDEV=/dev/ram0 so I didn't
need another block device on the machine just for an external
log on a throw-away filesystem....
> There are no explicit external log tests (logdev=) that I can see.
It should be easy to write one using files and multiple
loopback devices.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-07-02 2:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 5:14 [PATCH] Fix use after free when closing log/rt devices Lachlan McIlroy
2008-06-27 6:32 ` Christoph Hellwig
2008-06-27 6:39 ` Mark Goodwin
2008-06-27 9:08 ` Christoph Hellwig
2008-07-02 1:59 ` Timothy Shimmin
2008-07-02 2:54 ` Dave Chinner [this message]
2008-07-01 6:21 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080702025454.GW29319@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=markgw@sgi.com \
--cc=tes@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox