From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: Re: [patch] xfsqa 078 - use rmdir to remove directories
Date: Fri, 11 Jul 2008 08:42:38 +1000 [thread overview]
Message-ID: <20080710224237.GX11558@disturbed> (raw)
In-Reply-To: <20080522061120.GP173056135@sgi.com>
ping?
On Thu, May 22, 2008 at 04:11:20PM +1000, David Chinner wrote:
>
> If test 078 fails and you try to run it again immediately, it
> will execute a 'rm -f' on a directory which will fail. This should
> be a rmdir....
>
> Signed-off-by: Dave Chinner <dgc@sgi.com>
> ---
> xfstests/078 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: xfs-cmds/xfstests/078
> ===================================================================
> --- xfs-cmds.orig/xfstests/078 2008-03-20 09:10:02.000000000 +1100
> +++ xfs-cmds/xfstests/078 2008-05-15 23:21:58.192413673 +1000
> @@ -50,8 +50,8 @@ _filter_io()
> # real QA test starts here
>
> echo "*** create loop mount point"
> -rm -f $LOOP_MNT 2>/dev/null
> -mkdir $LOOP_MNT || _fail "cannot create loopback mount point"
> +rmdir $LOOP_MNT 2>/dev/null
> +mkdir -p $LOOP_MNT || _fail "cannot create loopback mount point"
>
> _grow_loop()
> {
>
>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2008-07-10 22:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 6:11 [patch] xfsqa 078 - use rmdir to remove directories David Chinner
2008-05-22 13:22 ` Christoph Hellwig
2008-07-10 22:42 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080710224237.GX11558@disturbed \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox